Implemented speaker detail page and enchanced model #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
epsy
requested changes
Jun 21, 2017
pybay/proposals/models.py
Outdated
| @@ -51,6 +51,7 @@ class Proposal(ProposalBase): | |||
| what_will_attendees_learn = models.TextField() | |||
| meetup_talk = models.CharField(choices=MEETUP_CHOICES, max_length=100, default="No") | |||
| speaker_and_talk_history = models.TextField() | |||
| speaker_website = models.TextField(null=True) | |||
There was a problem hiding this comment.
This should be blank=True
https://docs.djangoproject.com/en/1.11/ref/models/fields/#null
| <div class="container" style="padding-top: 150px;"> | ||
| <div class="row"> | ||
| <div class="col-sm-6 col-md-4"> | ||
| <a href="{{ speaker.photo.url }}" data-title="Meetup 2013"> |
| <h3>Abstract</h3> | ||
| {{ talk.abstract }} | ||
| </p> | ||
| <a href="#" class="btn"> Conference Schedule </a> |
There was a problem hiding this comment.
  shouldn't be necessary now that .btn has padding-left/right 15px
pybay/urls.py
Outdated
| @@ -56,6 +57,7 @@ | |||
| # url(r"^markitup/", include("markitup.urls")), | |||
| url(r"^our-sponsors/$", pybay_sponsors_list, name="pybay_sponsors_list"), | |||
| url(r"^our-speakers/$", pybay_speakers_list, name="pybay_speakers_list"), | |||
| url(r"^speaker/(?P<speaker_slug>[-\w]+)/$$", pybay_speakers_detail, name="pybay_speakers_detail"), | |||
pybay/utils.py
Outdated
|
|
||
| def get_accepted_speaker_by_slug(speaker_slug): | ||
| """ | ||
| This function is purpously done do avoid touching Symposion |
pybay/views.py
Outdated
| from django.views.generic import TemplateView | ||
|
|
||
| from .forms import CallForProposalForm | ||
| from pybay.faqs.models import Faq, Category | ||
| from symposion.sponsorship.models import Sponsor | ||
| from pybay.proposals.models import Proposal, TalkProposal, TutorialProposal | ||
| from pybay.proposals.models import TalkProposal, TutorialProposal |
pybay/views.py
Outdated
| log.error("Speaker %s does not have any approved talks or does not exist", speaker_slug) | ||
| return HttpResponseNotFound() | ||
|
|
||
| speaker_approved_talks = TalkProposal.objects.filter( |
There was a problem hiding this comment.
Use speaker.talk_proposal_set
epsy
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few fixes on model, queries and enables speaker detail page
Ticket: pybay/symposion#1